Update factorial_python.py #688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
solberg-eric commented Jan 31, 2019
solberg-eric commented - Add try/except to catch "ValueError: invalid literal for int() with base 10: '(user input)'" exception.
- Add try/except to catch "ValueError: invalid literal for int() with base 10: '(user input)'" exception.
Add try/catch incase the user does not input a number
poyea requested changes Feb 14, 2019
| print("Sorry, factorial does not exist for negative numbers") | ||
| elif num == 0: | ||
| print("The factorial of 0 is 1") | ||
| elif type(num) != |
There was a problem hiding this comment.
I believe you've made a mistake here. Can you modify that and resubmit it again?
| @poyea I marked this pull request as on hold. Therefore we have a better overview |
| Stale pull request message |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.