Skip to content

send email #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

send email #6634

wants to merge 2 commits into from

Conversation

@MohibBhojani
Copy link

@MohibBhojani MohibBhojani commented Oct 4, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@MohibBhojani
Copy link
Author

MohibBhojani commented Oct 4, 2022

send email
@MohibBhojani
Copy link
Author

MohibBhojani commented Oct 4, 2022

done
CaedenPH
CaedenPH reviewed Oct 4, 2022
View reviewed changes
Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this an algorithm?
@poyea
Copy link
Member

poyea commented Oct 5, 2022

Thanks, but this is not an "algorithm" and there are specific requirements in https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md on the purposes of this repository.
@poyea poyea closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@MohibBhojani @poyea @CaedenPH @abdulmohib