Create prime_generator.py #646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
prime generator was handy in several project Euler problems. Please suggest where to merge this function if it is not suitable as a stand alone file.
harshildarji requested changes Dec 6, 2018
There was a problem hiding this comment.
Hey @SandersLin,
As you said that prime_generator is useful in many Project Euler problems, I suggest you put this scipt in project_euler folder.
Thank you.
| Hi @harshildarji , thank you for taking the time to review my code! including |
| That's a nice idea. Such PRs are always welcomed! |
| Stale pull request message |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
prime generator was handy in several project Euler problems. Please suggest where to merge this function if it is not suitable as a stand alone file.