Skip to content

Unify O(sqrt(N)) is_prime functions under project_euler #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Unify O(sqrt(N)) is_prime functions under project_euler #6258

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1fbf132
fixes #5434
ngiachou Jul 19, 2022
2c9b49a
fixes broken solution
ngiachou Jul 20, 2022
a28245c
removes assert
ngiachou Jul 20, 2022
afafca5
removes assert
ngiachou Jul 20, 2022
74845c9
Apply suggestions from code review
ngiachou Jul 29, 2022
41da130
Update project_euler/problem_003/sol1.py
poyea Sep 14, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes broken solution
  • Loading branch information
@ngiachou
ngiachou committed Jul 20, 2022
commit 2c9b49a077c4304f1e25da50ead7c0deac4e3a48
11 changes: 2 additions & 9 deletions project_euler/problem_027/sol1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,10 @@ def is_prime(number: int) -> bool:
False
>>> is_prime(1)
False
>>> is_prime(3.14)
Traceback (most recent call last):
...
AssertionError: 'number' must been an int and positive
>>> is_prime(-10)
False
"""

# precondition
assert isinstance(number, int) and (
number >= 0
), "'number' must been an int and positive"

if 1 < number < 4:
# 2 and 3 are primes
return True
Expand Down