Skip to content

Unify primality checking #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2022
Merged

Unify primality checking #6228

merged 4 commits into from
Jul 11, 2022

Conversation

ngiachou
Copy link
Contributor

@ngiachou ngiachou commented Jul 4, 2022 •
edited
Loading

Describe your change:

I refactored some functions in order to fix #5434. More specifically,

  1. I changed the name of some function in order to agree with naming conventions.
  2. I changed the implementation of a primality checking function in order to have a O(sqrt(n)) time complexity algorithm.

There are some more functions that are related to primality checking namely the lucas_lehmer_primality_test.py and miller_rabin.py but I did not change these since they are specific algorithms.

I have searched for every mention of the word prime in all of the files and except from the project_euler I think that there are no other mentions on the primality testing subject.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ngiachou ngiachou requested a review from Kush1101 as a code owner July 4, 2022 00:02
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 4, 2022
@ngiachou
Copy link
Contributor Author

ngiachou commented Jul 4, 2022

I think I have done something wrong with my commit history... Is there a way of fixing this?
@ngiachou
Copy link
Contributor Author

ngiachou commented Jul 6, 2022

I think I have done something wrong with my commit history... Is there a way of fixing this?

Nevermind, fixed it!
@poyea poyea self-assigned this Jul 8, 2022
@poyea poyea mentioned this pull request Jul 11, 2022
Merged
14 tasks
poyea
poyea approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 11, 2022
@poyea
Copy link
Member

poyea commented Jul 11, 2022

It would be great if we can check against also the project_euler files. Let's merge this and have the updates in #5434
@poyea poyea merged commit f7c58e4 into TheAlgorithms:master Jul 11, 2022
@cclauss cclauss mentioned this pull request Oct 12, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

2 participants

@ngiachou @poyea