Skip to content

Conversation

@pikulet
Copy link
Contributor

@pikulet pikulet commented Nov 10, 2021

Describe your change:

Fixes #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 10, 2021
@l3str4nge l3str4nge merged commit 7e81551 into TheAlgorithms:master Nov 10, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 10, 2021
@cclauss
Copy link
Member

cclauss commented Nov 10, 2021

This pull request did NOT fix #4052. Reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

3 participants