Skip to content

Fix factorial issues #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Fix factorial issues #5496

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9121b12
updating DIRECTORY.md
Oct 21, 2021
6fcf1b8
pass integer to `math.factorial` in `project_euler/problem_015`
poyea Oct 21, 2021
d60dc64
remove duplicated factorial function
poyea Oct 21, 2021
78b0534
updating DIRECTORY.md
Oct 21, 2021
258816d
Update maths/factorial_iterative.py
poyea Oct 21, 2021
b85d78e
Update factorial_iterative.py
poyea Oct 21, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update factorial_iterative.py
  • Loading branch information
@poyea
poyea authored Oct 21, 2021
commit b85d78e1c9b831a3ac00aeb54c17f7633f50b46b
6 changes: 3 additions & 3 deletions maths/factorial_iterative.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ def factorial(number: int) -> int:
>>> factorial(0)
1
"""
if input_number != int(input_number):
if number != int(number):
raise ValueError("factorial() only accepts integral values")
if input_number < 0:
if number < 0:
raise ValueError("factorial() not defined for negative values")
value = 1
for i in range(1, input_number + 1):
for i in range(1, number + 1):
value *= i
return value

Expand Down