Skip to content

Update queue implementation #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2021
Merged

Update queue implementation #5388

merged 6 commits into from
Oct 30, 2021

Conversation

Crowton
Copy link
Contributor

@Crowton Crowton commented Oct 17, 2021

Popping the first element of a list takes O(n) time.
Using a cyclic queue takes O(1) time.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Crowton
Update queue implementation
02ecae7 
Popping the first element of a list takes O(n) time. Using a cyclic queue takes O(1) time.
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 17, 2021
This was referenced Oct 18, 2021
Closed
Closed
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 18, 2021
@poyea poyea self-assigned this Oct 20, 2021
@poyea poyea self-requested a review October 21, 2021 03:59
@Crowton
Copy link
Contributor Author

Crowton commented Oct 21, 2021

I am not sure about what line break is complaining - should there not be 2 lines between imports and general code?
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 25, 2021
@Crowton
Copy link
Contributor Author

Crowton commented Oct 27, 2021

Is it the doctests which are failing now? I don't know anymore
poyea
poyea reviewed Oct 27, 2021
View reviewed changes
poyea
poyea reviewed Oct 27, 2021
View reviewed changes
@poyea
Copy link
Member

poyea commented Oct 27, 2021

The test suite seems to be stuck
@Crowton @poyea
Apply suggestions from code review
700613e 
Co-authored-by: John Law <johnlaw.po@gmail.com>
poyea
poyea approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2021
@poyea poyea merged commit e6cf13c into TheAlgorithms:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

2 participants

@Crowton @poyea