Skip to content

DPLL algorithm #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 8, 2020
Merged

DPLL algorithm #3866

merged 8 commits into from
Nov 8, 2020

Conversation

@Shivanirudh
Copy link
Contributor

@Shivanirudh Shivanirudh commented Nov 6, 2020 •
edited by cclauss
Loading

Describe your change:

Added DPLL algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss
cclauss reviewed Nov 6, 2020
View reviewed changes
cclauss
cclauss reviewed Nov 6, 2020
View reviewed changes
cclauss
cclauss reviewed Nov 6, 2020
View reviewed changes
cclauss
cclauss reviewed Nov 6, 2020
View reviewed changes
@Shivanirudh Shivanirudh requested a review from cclauss November 7, 2020 14:10
cclauss
cclauss reviewed Nov 7, 2020
View reviewed changes
cclauss
cclauss requested changes Nov 7, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B
@Shivanirudh Shivanirudh requested a review from cclauss November 8, 2020 08:35
cclauss
cclauss requested changes Nov 8, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting there...
@Shivanirudh Shivanirudh requested a review from cclauss November 8, 2020 13:00
cclauss
cclauss approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc74417 I renamed the file to be self-documenting and made several optimizations including defining a .__len__() method and catching the RecursionError.
@cclauss cclauss merged commit eab6b70 into TheAlgorithms:master Nov 8, 2020
@Shivanirudh
Copy link
Contributor Author

Shivanirudh commented Nov 8, 2020

Yeah, thank you very much!
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Shivanirudh @cclauss @stokhos
DPLL algorithm (TheAlgorithms#3866)
17e9e6d 
* DPLL algorithm * Corrections complete * Formatting * Codespell hook * Corrections part 2 * Corrections v2 * Corrections v3 * Update and rename dpll.py to davis–putnam–logemann–loveland.py Co-authored-by: Christian Clauss <cclauss@me.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@Shivanirudh @cclauss @peRFectBeliever
DPLL algorithm (TheAlgorithms#3866)
85c7adf 
* DPLL algorithm * Corrections complete * Formatting * Codespell hook * Corrections part 2 * Corrections v2 * Corrections v3 * Update and rename dpll.py to davis–putnam–logemann–loveland.py Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Shivanirudh @cclauss
DPLL algorithm (TheAlgorithms#3866)
5df9bd8 
* DPLL algorithm * Corrections complete * Formatting * Codespell hook * Corrections part 2 * Corrections v2 * Corrections v3 * Update and rename dpll.py to davis–putnam–logemann–loveland.py Co-authored-by: Christian Clauss <cclauss@me.com>
@hit701
Copy link

hit701 commented Jun 19, 2021

Dear
I just knew this site from GitHub algorithm/python.
I would like to research algorithm for education interest.
Regard Hitoshi
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@Shivanirudh @cclauss @shermanhui
DPLL algorithm (TheAlgorithms#3866)
c14cfa1 
* DPLL algorithm * Corrections complete * Formatting * Codespell hook * Corrections part 2 * Corrections v2 * Corrections v3 * Update and rename dpll.py to davis–putnam–logemann–loveland.py Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Shivanirudh @hit701 @cclauss