Skip to content

Hacktoberfest:Added first solution to Project Euler problem 92 #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Hacktoberfest:Added first solution to Project Euler problem 92 #3626

wants to merge 1 commit into from

Conversation

sharmapulkit04
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2020
dhruvmanila
dhruvmanila requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Descriptive function and variable names throughout the code
  • Better type hints: List[type1, type2, ...]
@dhruvmanila dhruvmanila added require type hints https://docs.python.org/3/library/typing.html awaiting changes A maintainer has requested changes to this PR labels Oct 28, 2020
@stale
Copy link

stale bot commented Nov 27, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 27, 2020
@stale
Copy link

stale bot commented Dec 5, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!
@stale stale bot closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require type hints https://docs.python.org/3/library/typing.html stale Used to mark an issue or pull request stale.

4 participants

@sharmapulkit04 @kbakdev @dhruvmanila @poyea