Update merge_sort_fastest.py #302
Conversation
| Hello @yesIamHasi, It would be really helpful if you could you please let use know about the inputs for which current code is not working as expected? |
| # Basic Test | ||
| LIST = [0,5,2,4,3,9,1,7,6,8] | ||
| print ('Unordered list {}'.format(LIST)) | ||
| print ('Merge sorted list {}'.format(merge_sort(LIST))) |
There was a problem hiding this comment.
can we store the merge_sort(LIST) into some variable and then use it at multiple places?
| ''' | ||
| # These modules are required for testing only. | ||
| import random, copy | ||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Umm, it's nice to see the output as graph, it really helps in visualising the data. But I think it's not required here. We can just test for the output.
There was a problem hiding this comment.
@AnshulMalik
good point! The function min and max have O(n). And this runtime is dominant.
The graphic output is nice feature I would retain it.
| ''' | ||
| Plots unsorted and sorted data. | ||
| ''' | ||
| plt.plot(LIST) |
There was a problem hiding this comment.
Changed the code like this:
figure1 = plt.figure(1) plt.plot(LIST) plt.xlabel('Random Data') figure1.show() figure2 = plt.figure(2) plt.plot(SORTED_LIST) plt.xlabel('Merge Sorted Data') figure2.show() raw_input() # keeps the figures aliveWith the code above it show up two figures parallel at the same time.
5 participants
Thank you very much for pointing that out. I am really sorry I accidentally uploaded the wrong file last time. The changes you made didn't worked for some inputs. This one works fine.