Create Fibonacci.py #286
Closed
Create Fibonacci.py #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This script contains python implementation of Fibonacci sequence in two forms. 1) Formula Implementation. 2) Iterative Implementation.
| #286 the code isn't correct |
christianbender requested changes Apr 14, 2018
| class Fibonacci: | ||
| def formula(self, n): | ||
| '''Return nth fibonacci number using formula.''' | ||
| return int( ((1+sqrt(5))**n-(1-sqrt(5))**n)/(2**n*sqrt(5)) ) |
There was a problem hiding this comment.
This line contains a bug. You must write in the head
from math import sqrtfor using the sqrt(...) function.
| a,b = b, a+b | ||
| return b-a | ||
| | ||
| def fibrange(self, start, stop, fast=True): |
There was a problem hiding this comment.
Use list compreshion
if not fast: fib_range = [self.iteration(i) for i in range(start,stop)] return fib_range else: fib_range = [self.formula(i) for i in range(start,stop)] return fib_range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This script contains python implementation of Fibonacci sequence in two forms.