Skip to content

binary_to_decimal converter #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 11, 2020
Merged

binary_to_decimal converter #2400

merged 5 commits into from
Sep 11, 2020

Conversation

@mohammadreza490
Copy link
Contributor

@mohammadreza490 mohammadreza490 commented Sep 6, 2020 •
edited
Loading

binary to decimal converter

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@mohammadreza490
Create binary_to_decimal
0a6dff6 
binary to decimal converter
cclauss
cclauss reviewed Sep 6, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 6, 2020
View reviewed changes
mohammadreza490 and others added 2 commits September 6, 2020 10:55
@mohammadreza490 @cclauss
Update conversions/binary_to_decimal
7da5d1a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@mohammadreza490
Update binary_to_decimal
6dc56f6
cclauss
cclauss reviewed Sep 7, 2020
View reviewed changes
cclauss
cclauss reviewed Sep 7, 2020
View reviewed changes
mohammadreza490 and others added 2 commits September 7, 2020 08:42
@mohammadreza490 @cclauss
Update conversions/binary_to_decimal
ce694fc 
Co-authored-by: Christian Clauss <cclauss@me.com>
@mohammadreza490
Update binary_to_decimal
f2f3069
@mohammadreza490
Copy link
Contributor Author

mohammadreza490 commented Sep 10, 2020

@cclauss
hey, can you also check this one please?

Thanks
cclauss
cclauss approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
@cclauss cclauss merged commit 1b3fec3 into TheAlgorithms:master Sep 11, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mohammadreza490 @cclauss @stokhos
binary_to_decimal converter (TheAlgorithms#2400)
d9cce44 
* Create binary_to_decimal binary to decimal converter * Update conversions/binary_to_decimal Co-authored-by: Christian Clauss <cclauss@me.com> * Update binary_to_decimal * Update conversions/binary_to_decimal Co-authored-by: Christian Clauss <cclauss@me.com> * Update binary_to_decimal Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mohammadreza490 @cclauss