Created problem_34 in project_euler #2305

Kush1101 · 2020-08-13T12:00:28Z

Describe your change:

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

I have read CONTRIBUTING.md.
This pull request is all my own work -- I have not plagiarized.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new Python files are placed inside an existing directory.
All filenames are in all lowercase characters with no spaces or dashes.
All functions and variable names follow Python naming conventions.
All function parameters and return values are annotated with Python type hints.
All functions have doctests that pass the automated testing.
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

TravisBuddy · 2020-08-13T12:03:58Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 10bc62e0-dd5d-11ea-9bc7-ef10f4dac8ce

TravisBuddy · 2020-08-13T12:17:46Z

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e262c6d0-dd5e-11ea-9bc7-ef10f4dac8ce

TravisBuddy · 2020-08-13T12:31:45Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f1cd8b80-dd60-11ea-9bc7-ef10f4dac8ce

TravisBuddy · 2020-08-13T12:36:27Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9a6b2220-dd61-11ea-9bc7-ef10f4dac8ce

TravisBuddy · 2020-08-13T12:46:47Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0b87c750-dd63-11ea-9bc7-ef10f4dac8ce

TravisBuddy · 2020-08-13T12:49:36Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6ffe9ec0-dd63-11ea-9bc7-ef10f4dac8ce

Kush1101 · 2020-08-13T12:50:42Z

How do I create the init.py file so that it passes the tests?
I am only failing in the init.py test.
It says
Blank line at end of file.
I have removed it but still, it won't pass.
@cclauss sir, Please help.

Kush1101 · 2020-08-13T13:12:50Z

Thank You sir for your help. Hope this gets merged 🤞.

project_euler/problem_34/sol1.py

Incorporates the proposed changes

TravisBuddy · 2020-08-13T13:37:18Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1a5d5ea0-dd6a-11ea-9bc7-ef10f4dac8ce

cclauss · 2020-08-13T13:38:00Z

project_euler/problem_34/sol1.py

 if sum_of_digit_factorial(num) == num:
- summ += num
- return summ
+ the_list.append(num)


Could we make this list using a https://docs.python.org/3/tutorial/datastructures.html#list-comprehensions

Ok sir. Will do it

project_euler/problem_34/sol1.py

Co-authored-by: Christian Clauss <cclauss@me.com>

project_euler/problem_34/sol1.py

TravisBuddy · 2020-08-13T14:04:14Z

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dc9a1280-dd6d-11ea-9bc7-ef10f4dac8ce

project_euler/problem_34/sol1.py

TravisBuddy · 2020-08-13T14:06:13Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 240dd9d0-dd6e-11ea-9bc7-ef10f4dac8ce

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-08-13T14:16:12Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 89579c30-dd6f-11ea-9bc7-ef10f4dac8ce

cclauss · 2020-08-13T14:19:53Z

Looks good to me... Should we land it??

TravisBuddy · 2020-08-13T14:22:32Z

Travis tests have failed

Hey @Kush1101,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6ada79c0-dd70-11ea-9bc7-ef10f4dac8ce

Kush1101 · 2020-08-13T14:29:37Z

If the tests pass then can you please merge it.
@cclauss
The continuous failure is because of the tests is because of the syntax rules. I am not able to run black on my computer that is why the syntax errors are not being resolved.

Kush1101 · 2020-08-13T14:47:36Z

@cclauss
Can we merge now sir?

cclauss

Awesome work here! Thanks for your persistence.

TravisBuddy · 2020-08-13T14:53:23Z

Hey @Kush1101,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: baf625e0-dd74-11ea-9bc7-ef10f4dac8ce

Kush1101 · 2020-08-13T14:54:55Z

@cclauss Thank you sir for your patience.
I know you are extremely busy and I occupied too much of your attention.
I am a beginner sir and I will learn as I keep going under mentors like you. Thanks once again, sir. ✌

* Create __init__.py * Add files via upload * Rename solution.py.py to solution.py * Delete __init__.py * Update and rename solution.py to sol1.py * Update sol1.py * Create __init__.py * Update __init__.py * Delete __init__.py * Add files via upload * Update __init__.py * Add #\n * Update sol1.py Incorporates the proposed changes * Update sol1.py * Update sol1.py * Update project_euler/problem_34/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_34/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_34/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update project_euler/problem_34/sol1.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update sol1.py * Update sol1.py * Update sol1.py * Use int(n) instead of floor(n) Co-authored-by: Christian Clauss <cclauss@me.com>

Kush1101 added 5 commits August 13, 2020 17:22

Create __init__.py

dcdaa1e

Add files via upload

16f0943

Rename solution.py.py to solution.py

f7d92f8

Delete __init__.py

a915dea

Update and rename solution.py to sol1.py

c47288c

Update sol1.py

632b838

Create __init__.py

f801415

Update __init__.py

39bdd95

Kush1101 added 3 commits August 13, 2020 18:06

Delete __init__.py

2cf433f

Add files via upload

0e7d56b

Update __init__.py

b5a56bb

Add #\n

fd043c0

cclauss requested changes Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Show resolved Hide resolved

project_euler/problem_34/sol1.py Outdated Show resolved Hide resolved

Update sol1.py

e551e5a

Incorporates the proposed changes

cclauss reviewed Aug 13, 2020

View reviewed changes

Kush1101 added 2 commits August 13, 2020 19:11

Update sol1.py

5e92188

Update sol1.py

0cf3459

cclauss reviewed Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Outdated Show resolved Hide resolved

cclauss reviewed Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Outdated Show resolved Hide resolved

Kush1101 and others added 2 commits August 13, 2020 19:32

Update project_euler/problem_34/sol1.py

07e43df

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_34/sol1.py

5d76c7e

Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss reviewed Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Outdated Show resolved Hide resolved

cclauss reviewed Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Outdated Show resolved Hide resolved

cclauss reviewed Aug 13, 2020

View reviewed changes

project_euler/problem_34/sol1.py Show resolved Hide resolved

Kush1101 and others added 3 commits August 13, 2020 19:41

Update project_euler/problem_34/sol1.py

b5e771f

Co-authored-by: Christian Clauss <cclauss@me.com>

Update project_euler/problem_34/sol1.py

8f0b7c1

Co-authored-by: Christian Clauss <cclauss@me.com>

Update sol1.py

bd0849a

Update sol1.py

53cf0a5

Update sol1.py

b038727

Use int(n) instead of floor(n)

4c38019

cclauss approved these changes Aug 13, 2020

View reviewed changes

cclauss merged commit b3ae392 into TheAlgorithms:master Aug 13, 2020

Kush1101 mentioned this pull request Aug 25, 2020

Travis CI: Identify our ten slowest pytests #2350

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Created problem_34 in project_euler #2305

Created problem_34 in project_euler #2305

Uh oh!

Kush1101 commented Aug 13, 2020 •

edited

Loading

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

Kush1101 commented Aug 13, 2020 •

edited

Loading

Kush1101 commented Aug 13, 2020

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

cclauss Aug 13, 2020

Kush1101 Aug 13, 2020

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

cclauss commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

Kush1101 commented Aug 13, 2020 •

edited

Loading

Kush1101 commented Aug 13, 2020

cclauss left a comment

TravisBuddy commented Aug 13, 2020

Kush1101 commented Aug 13, 2020 •

edited

Loading

Labels

3 participants

Uh oh!

Created problem_34 in project_euler #2305

Created problem_34 in project_euler #2305

Uh oh!

Conversation

Kush1101 commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 10bc62e0-dd5d-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

Travis tests have failed

TravisBuddy Request Identifier: e262c6d0-dd5e-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: f1cd8b80-dd60-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 9a6b2220-dd61-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 0b87c750-dd63-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 6ffe9ec0-dd63-11ea-9bc7-ef10f4dac8ce

Kush1101 commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kush1101 commented Aug 13, 2020

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 1a5d5ea0-dd6a-11ea-9bc7-ef10f4dac8ce

cclauss Aug 13, 2020

Choose a reason for hiding this comment

Kush1101 Aug 13, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

Travis tests have failed

TravisBuddy Request Identifier: dc9a1280-dd6d-11ea-9bc7-ef10f4dac8ce

Uh oh!

Uh oh!

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 240dd9d0-dd6e-11ea-9bc7-ef10f4dac8ce

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: 89579c30-dd6f-11ea-9bc7-ef10f4dac8ce

cclauss commented Aug 13, 2020

TravisBuddy commented Aug 13, 2020

Travis tests have failed

TravisBuddy Request Identifier: 6ada79c0-dd70-11ea-9bc7-ef10f4dac8ce

Kush1101 commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kush1101 commented Aug 13, 2020

cclauss left a comment

Choose a reason for hiding this comment

TravisBuddy commented Aug 13, 2020

TravisBuddy Request Identifier: baf625e0-dd74-11ea-9bc7-ef10f4dac8ce

Kush1101 commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Labels

3 participants

Kush1101 commented Aug 13, 2020 •

edited

Loading

Kush1101 commented Aug 13, 2020 •

edited

Loading

Kush1101 commented Aug 13, 2020 •

edited

Loading

Kush1101 commented Aug 13, 2020 •

edited

Loading