Skip to content

Conversation

NANDAGOPALNG
Copy link

Describe your change:

This project demonstrates text-driven image segmentation using Meta's Segment Anything Model 2 (SAM 2). The implementation focuses on converting various input prompts (points, boxes) into precise object segmentation masks.

can you assign me this under Hacktoberfest 2025

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeper algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 15, 2025
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

os.environ["PYTORCH_ENABLE_MPS_FALLBACK"] = "1"


def setup_device():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: setup_device. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function setup_device

rng = np.random.default_rng(3)


def show_mask(mask, ax, random_color=False, borders=True):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: show_mask. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function show_mask

Please provide type hint for the parameter: mask

Please provide type hint for the parameter: ax

Please provide type hint for the parameter: random_color

Please provide type hint for the parameter: borders

ax.imshow(mask_image)


def show_points(coords, labels, ax, marker_size=375):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: show_points. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function show_points

Please provide type hint for the parameter: coords

Please provide type hint for the parameter: labels

Please provide type hint for the parameter: ax

Please provide type hint for the parameter: marker_size

)


def show_box(box, ax):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: show_box. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function show_box

Please provide type hint for the parameter: box

Please provide type hint for the parameter: ax

)


def show_masks(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: show_masks. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function show_masks

return masks, scores


def demonstrate_box_prompt(predictor, image):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: demonstrate_box_prompt. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function demonstrate_box_prompt

Please provide type hint for the parameter: predictor

Please provide type hint for the parameter: image

return masks, scores


def demonstrate_combined_prompts(predictor, image):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: demonstrate_combined_prompts. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function demonstrate_combined_prompts

Please provide type hint for the parameter: predictor

Please provide type hint for the parameter: image

return masks, scores


def demonstrate_batched_prompts(predictor, image):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: demonstrate_batched_prompts. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function demonstrate_batched_prompts

Please provide type hint for the parameter: predictor

Please provide type hint for the parameter: image

return masks, scores


def demonstrate_batched_images(predictor):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: demonstrate_batched_images. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function demonstrate_batched_images

Please provide type hint for the parameter: predictor

plt.show()


def main():

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py, please provide doctest for the function main

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 15, 2025
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass

1 participant