-
- Notifications
You must be signed in to change notification settings - Fork 48.7k
Added Image Segmentation which fixes #13516 #13518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper
commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper review
to trigger the checks for only added pull request files@algorithms-keeper review-all
to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
os.environ["PYTORCH_ENABLE_MPS_FALLBACK"] = "1" | ||
| ||
| ||
def setup_device(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: setup_device
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function setup_device
rng = np.random.default_rng(3) | ||
| ||
| ||
def show_mask(mask, ax, random_color=False, borders=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: show_mask
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function show_mask
Please provide type hint for the parameter: mask
Please provide type hint for the parameter: ax
Please provide type hint for the parameter: random_color
Please provide type hint for the parameter: borders
ax.imshow(mask_image) | ||
| ||
| ||
def show_points(coords, labels, ax, marker_size=375): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: show_points
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function show_points
Please provide type hint for the parameter: coords
Please provide type hint for the parameter: labels
Please provide type hint for the parameter: ax
Please provide type hint for the parameter: marker_size
) | ||
| ||
| ||
def show_box(box, ax): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: show_box
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function show_box
Please provide type hint for the parameter: box
Please provide type hint for the parameter: ax
) | ||
| ||
| ||
def show_masks( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: show_masks
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function show_masks
return masks, scores | ||
| ||
| ||
def demonstrate_box_prompt(predictor, image): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: demonstrate_box_prompt
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function demonstrate_box_prompt
Please provide type hint for the parameter: predictor
Please provide type hint for the parameter: image
return masks, scores | ||
| ||
| ||
def demonstrate_combined_prompts(predictor, image): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: demonstrate_combined_prompts
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function demonstrate_combined_prompts
Please provide type hint for the parameter: predictor
Please provide type hint for the parameter: image
return masks, scores | ||
| ||
| ||
def demonstrate_batched_prompts(predictor, image): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: demonstrate_batched_prompts
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function demonstrate_batched_prompts
Please provide type hint for the parameter: predictor
Please provide type hint for the parameter: image
return masks, scores | ||
| ||
| ||
def demonstrate_batched_images(predictor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: demonstrate_batched_images
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function demonstrate_batched_images
Please provide type hint for the parameter: predictor
plt.show() | ||
| ||
| ||
def main(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide return type hint for the function: main
. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file computer_vision/image_segmentation_sam2.py
, please provide doctest for the function main
for more information, see https://pre-commit.ci
Describe your change:
This project demonstrates text-driven image segmentation using Meta's Segment Anything Model 2 (SAM 2). The implementation focuses on converting various input prompts (points, boxes) into precise object segmentation masks.
can you assign me this under Hacktoberfest 2025
Checklist: