Skip to content

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented May 13, 2025

Describe your change:

Fixes: #12732

@lukazlim


  • Fix algorithms?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@cclauss cclauss changed the title Lukazlim: Replace dependency requests with httpx Lukazlim: Replace dependency requests with httpx May 13, 2025
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass awaiting reviews This PR is ready to be reviewed labels May 13, 2025
@cclauss cclauss force-pushed the lukazlim-master branch 3 times, most recently from e9fb6cd to 746be9c Compare May 13, 2025 13:57
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 13, 2025
Fixes TheAlgorithms#12742 Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
@cclauss cclauss force-pushed the lukazlim-master branch from 0465935 to 7023df9 Compare May 13, 2025 14:00
@cclauss cclauss requested a review from MaximSmolskiy May 13, 2025 14:02
@cclauss cclauss enabled auto-merge (squash) May 13, 2025 14:04
@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels May 13, 2025
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels May 14, 2025
@cclauss cclauss requested a review from MaximSmolskiy May 14, 2025 01:05
@cclauss cclauss merged commit a2fa32c into TheAlgorithms:master May 14, 2025
7 checks passed
@cclauss cclauss deleted the lukazlim-master branch May 14, 2025 05:25
@cclauss
Copy link
Member Author

cclauss commented May 14, 2025

@lukazlim Thanks much for doing this! Would you be willing to create another pull request that adds a README.md to the web_programming directory? THA file could contain a list or table of the algorithms and the results of running them.

Status:

  • Works as expected.
  • Requires an API token.
  • Broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

3 participants