Skip to content

Conversation

@SajeevSenthil
Copy link
Contributor

Describe your change:

  • Add an algorithm

This pull request adds a new script that calculates the escape velocity of a celestial body using the standard physics formula:
v = sqrt((2GM)/R)

The file is placed in the physics/ directory and contains:

  • Edge case handling (zero mass or radius)
  • Doctests for validation
  • Type hints
  • Command-line interface for user input

No existing code was modified.


Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, I have not included unrelated changes.
  • All new Python files are placed inside an existing directory (physics/).
  • All filenames are in all lowercase characters with no spaces or dashes (escape_velocity.py).
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
    (No direct link included as it's a standard textbook formula)
  • This pull request does not resolve any open issues.
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 10, 2025
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 10, 2025
@algorithms-keeper algorithms-keeper bot removed tests are failing Do not merge until tests pass labels May 10, 2025
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass labels May 10, 2025
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label May 10, 2025
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label May 10, 2025
@algorithms-keeper algorithms-keeper bot removed tests are failing Do not merge until tests pass labels May 10, 2025
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label May 10, 2025
@MaximSmolskiy MaximSmolskiy merged commit 95fb181 into TheAlgorithms:master May 10, 2025
5 checks passed
imSanko added a commit to imSanko/Python that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants