Skip to content

Conversation

@Alfredoxrock
Copy link
Contributor

@Alfredoxrock Alfredoxrock commented May 2, 2025

  • Combined the ans_index and ans_length into a single tuple to track the best match (position + length) more cleanly.

  • Early exit for empty strings.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
Alfredoxrock and others added 2 commits May 2, 2025 10:51
- Combined the ans_index and ans_length into a single tuple to track the best match (position + length) more cleanly. - Early exit for empty strings.
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 2, 2025
@mindaugl
Copy link
Contributor

mindaugl commented May 3, 2025

This is a cosmetic change to the original implementation of the algorithm.

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels May 10, 2025
@MaximSmolskiy MaximSmolskiy merged commit 47a44ab into TheAlgorithms:master May 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failing Do not merge until tests pass

3 participants