Skip to content

Conversation

IBR-41379
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
IBR-41379 and others added 30 commits October 10, 2023 22:37
changed general df variable name to more of a sensible name.
 suggested changes changed Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 11, 2023
@IBR-41379
Copy link
Author

Finally my all tests have passes

@cclauss
Copy link
Member

cclauss commented Oct 11, 2023

I feel uncomfortable with this... https://en.wikipedia.org/wiki/Churn_rate describes the churn rate as a percentage over a given period such as 25% per year. This calculation is truncating the output for unspecified reasons and also does not deliver a percentage over a given period. The datafile is 10k lines which is quite substantial compared to other algorithms while the code delivers an output that is a bit baffling.

@tianyizheng02 @ChrisO345 Are you seeing something that I am not?

@cclauss cclauss changed the title Made changes for the test Chrun Rate yet again Oct 11, 2023
@IBR-41379
Copy link
Author

Well for me, churn rate is the turnover rate of the customer from a company. This is a sample dataset I acquired from IBM skillset. Initially my program was simple with much more info. But due to various failing test(ruff, build) I had to modify quite a lot of thing, remove quite a lot of things to make it compatible. If this repo accepted jupyter notebooks, I could have shown in much more great detail. And the main purpose of the program is to show how decision tree classifier predicts.

@IBR-41379
Copy link
Author

Well, my first first pull request is yet to be accepted. Let's see how it goes. Be sure to let me know what changes should I make.

@cclauss
Copy link
Member

cclauss commented Oct 11, 2023

Please submit the original on https://github.com/TheAlgorithms/Jupyter and @mention me on that submission so perhaps we can land it there. They have much easier requirements.

@IBR-41379 IBR-41379 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

2 participants