added DecimalToHex #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| This pull request introduces 1 alert when merging 859a83b into 2d50357 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
ms10398 requested changes Oct 23, 2018
Member
ms10398 left a comment
ms10398 left a comment There was a problem hiding this comment.
Please fix the alert posted above
Contributor Author
| @ms10398 github says it’s up to date when i push but it isn’t and luhn.js should be in another branch |
Contributor Author
| @AlexDvorak BUG: console.log(decimalToHex(125)); // should be 7D but it was DFIX Change your function function decimalToHex(num){ let hex_out = []; while(num > 15) { hex_out.push(intToHex(num%16)); num = Math.floor(num / 16); } return intToHex(num) + hex_out.join(""); // BUG FIX } |
christianbender added bug | @AlexDvorak Please seperate your pull request in multilpe PRs. One for each filing. |
christianbender requested changes Feb 17, 2019
Member
| This pull request introduces 1 alert when merging 97ac1c3 into 9cabd46 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
ms10398 approved these changes Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
contributes to #14