Skip to content

Create NumberExponentiation.js #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Create NumberExponentiation.js #381

wants to merge 1 commit into from

Conversation

@illegalcall
Copy link
Contributor

@illegalcall illegalcall commented Oct 2, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
itsvinayak
itsvinayak reviewed Oct 5, 2020
View reviewed changes
Recursive/NumberExponentiation.js
@@ -0,0 +1,19 @@
// Implement a fuction which calculates a number raised to the power n.

var myPow = function (x, n) {
Copy link
Member

@itsvinayak itsvinayak Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use arrow function.
  • use the proper function name .
  • provide doc
itsvinayak
itsvinayak requested changes Oct 5, 2020
View reviewed changes
Recursive/NumberExponentiation.js
return n < 0 ? 1 / result : result
}

function main () {
Copy link
Member

@itsvinayak itsvinayak Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write this function as
(()=>{ // code })()
@itsvinayak itsvinayak added beginner-friendly Easy to implement changes required This pull request needs changes good first issue labels Oct 5, 2020
@stale
Copy link

stale bot commented Feb 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix Will not be fixed or is a feature label Feb 14, 2021
@stale
Copy link

stale bot commented Mar 19, 2021

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.
@stale stale bot closed this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner-friendly Easy to implement changes required This pull request needs changes wontfix Will not be fixed or is a feature

2 participants

@illegalcall @itsvinayak