-
- Notifications
You must be signed in to change notification settings - Fork 5.8k
Removed command to install JS standard style #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| $ npm install standard --save-dev | ||
| ``` | ||
| - Usage | ||
| - Usage of JavaScript Standard Style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @Swapnil-2001 please, explain your changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard module is already included, so I was wondering if we can do without installing it everytime we make changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is but CONTRIBUTING.md shows the use cases and how to run modules
its an outline template and guidelines to contribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it just tells if you want to install standard user can use this command
but it could be better if we use npx in place of npm
@Swapnil-2001 can use replace npm command with npx one
so if anyone want to test a file without installing(npm install) they can do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, my apologies, I didn't understand that bit.
| $ npm install standard --save-dev | ||
| ``` | ||
| - Usage | ||
| - Usage of JavaScript Standard Style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is but CONTRIBUTING.md shows the use cases and how to run modules
its an outline template and guidelines to contribute
| $ npm install standard --save-dev | ||
| ``` | ||
| - Usage | ||
| - Usage of JavaScript Standard Style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it just tells if you want to install standard user can use this command
but it could be better if we use npx in place of npm
@Swapnil-2001 can use replace npm command with npx one
so if anyone want to test a file without installing(npm install) they can do that
| @@ -0,0 +1,25 @@ | |||
| // Palindrome check is case sensitive; i.e. Aba is not a palindrome | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this commit from this pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked up on the net on how to remove commits from pull requests but I didn't get a definite solution, could you please tell me how to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have to pull from origin/master of the original repo before pushing it to your fork copy
you can use git remote add origin2 "link of origin repo" and pull from it
before pulling and making changes reset to an old commit where you want to reset
use git reset --hard <hash value> to get hash value use git log
so:
- git log
get hash - git reset --hard [ hash value ]
- git remote add origin2 https://github.com/TheAlgorithms/Javascript.git
- git pull origin2 master
and now you make changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see if this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
I've followed all the steps but I cannot figure out what changes to make after this
Welcome to JavaScript community
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.