Skip to content

Conversation

@Swapnil-2001
Copy link
Contributor

@Swapnil-2001 Swapnil-2001 commented Jul 1, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
$ npm install standard --save-dev
```
- Usage
- Usage of JavaScript Standard Style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @Swapnil-2001 please, explain your changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard module is already included, so I was wondering if we can do without installing it everytime we make changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is but CONTRIBUTING.md shows the use cases and how to run modules
its an outline template and guidelines to contribute

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it just tells if you want to install standard user can use this command

but it could be better if we use npx in place of npm
@Swapnil-2001 can use replace npm command with npx one
so if anyone want to test a file without installing(npm install) they can do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, my apologies, I didn't understand that bit.

$ npm install standard --save-dev
```
- Usage
- Usage of JavaScript Standard Style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is but CONTRIBUTING.md shows the use cases and how to run modules
its an outline template and guidelines to contribute

$ npm install standard --save-dev
```
- Usage
- Usage of JavaScript Standard Style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it just tells if you want to install standard user can use this command

but it could be better if we use npx in place of npm
@Swapnil-2001 can use replace npm command with npx one
so if anyone want to test a file without installing(npm install) they can do that

@@ -0,0 +1,25 @@
// Palindrome check is case sensitive; i.e. Aba is not a palindrome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this commit from this pull

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked up on the net on how to remove commits from pull requests but I didn't get a definite solution, could you please tell me how to do this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to pull from origin/master of the original repo before pushing it to your fork copy
you can use git remote add origin2 "link of origin repo" and pull from it
before pulling and making changes reset to an old commit where you want to reset
use git reset --hard <hash value> to get hash value use git log

so:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see if this works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
I've followed all the steps but I cannot figure out what changes to make after this

@itsvinayak itsvinayak closed this Jul 3, 2020
@Swapnil-2001 Swapnil-2001 deleted the branch4 branch July 3, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants