Skip to content

Added Web-Programming (Open Weather Maps data fetch) #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2020
Merged

Added Web-Programming (Open Weather Maps data fetch) #196

merged 2 commits into from
Jun 21, 2020

Conversation

@ruppysuppy
Copy link
Member

@ruppysuppy ruppysuppy commented Jun 21, 2020 •
edited
Loading

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • Fixes: Addition of Web Programming #187
itsvinayak
itsvinayak requested changes Jun 21, 2020
View reviewed changes
Web-Programming/OpenWeatherMaps.js
@@ -0,0 +1,31 @@
const fetch = require('node-fetch')
Copy link
Member

@itsvinayak itsvinayak Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this requirement,
we can add a common package.json file which can be used to install all requirements using
npm install

and please remove package-lock.json file
thank you @ruppysuppy
Copy link
Member

@itsvinayak itsvinayak Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please add a global package.json file
Copy link
Member Author

@ruppysuppy ruppysuppy Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a global package.json file and removed package-lock.json but the HeapSort was causing some issues, I didn't touch it but it was modified by itself.
@itsvinayak itsvinayak mentioned this pull request Jun 21, 2020
Merged
11 tasks
@itsvinayak itsvinayak merged commit 412995a into TheAlgorithms:master Jun 21, 2020
@itsvinayak
Copy link
Member

itsvinayak commented Jun 21, 2020

nice work !!
@ruppysuppy
Copy link
Member Author

ruppysuppy commented Jun 22, 2020

Thanks a lot for helping me out with the branch issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ruppysuppy @itsvinayak