Skip to content

sort/ #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

sort/ #150

merged 1 commit into from
May 5, 2020

Conversation

@itsvinayak
Copy link
Member

@itsvinayak itsvinayak commented May 5, 2020

/* eslint no-extend-native: ["off", { "exceptions": ["Object"] }] */

this can be used to turn off eslint, as according to eslint extending native objects is bad
@itsvinayak itsvinayak requested a review from cclauss May 5, 2020 12:13
@cclauss
Copy link
Member

cclauss commented May 5, 2020

Not a fan of this approach. The linter is correct that Array prototype is read only.

Can't we find a way to resolve this that does not cause the linter to complain.
@itsvinayak
Copy link
Member Author

itsvinayak commented May 5, 2020 via email

@cclauss cclauss merged commit d37af25 into TheAlgorithms:master May 5, 2020
@cclauss cclauss mentioned this pull request May 5, 2020
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@itsvinayak @cclauss