Graph2: Naming Clarifications and Example #1474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Made a couple changes: 1. Explicit names for clarification of intent 2. `printGraph` string interpolation for readability 3. Example usage
appgurueu reviewed Oct 8, 2023
| // get the list for vertex v and put the | ||
| // vertex w denoting edge between v and w | ||
| this.AdjList.get(v).push(w) | ||
| addEdge(vertex1, vertex2) { |
There was a problem hiding this comment.
v and w are typical names for vertices. vertex1 and vertex2 is less readable.
There was a problem hiding this comment.
Would it be best to close this out and leave the file with naming as is? There could be better things to focus on with your time. I am game for that if you think all is good right now.
There was a problem hiding this comment.
It's not major, but it is a minor change for the worse, IMO.
There was a problem hiding this comment.
Ok. Thanks for the feedback @appgurueu
appgurueu reviewed Oct 8, 2023
| graph.addVertex("C"); | ||
| graph.addEdge("A", "B"); | ||
| graph.addEdge("A", "C"); | ||
| graph.printGraph(); |
There was a problem hiding this comment.
No side effects. Don't just put an example here. Put it in a JSDoc @example or in the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe your change:
Made a couple changes:
printGraphstring interpolation for readabilityChecklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.