Skip to content

Conversation

@AmbrishRamachandiran
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
Signed-off-by: AmbrishRamachandiran <ambrish.r@infosys.com>
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This is implementing a hash table in terms of a hash table (JS objects are hash tables), which is obviously trivial. You should be implementing a hash table in terms of an array.
  • This makes no attempt at dealing with collisions (pretty much the only interesting part about hash tables); instead, it will just exhibit incorrect behavior and consider keys with equal hashes equal.
@appgurueu appgurueu closed this Oct 7, 2023
@AmbrishRamachandiran AmbrishRamachandiran deleted the hashtablesearch branch October 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants