Skip to content

Conversation

@debnath003
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@debnath003
Copy link
Author

@appgurueu @raklaptudirm please approve this PR and merge this so that it can be eligible for hacktoberfest

@debnath003
Copy link
Author

@appgurueu @raklaptudirm please check my PR #1413 and approve for hacktoberfest

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this is trivial. I don't see any algorithmic value yet.

@appgurueu appgurueu closed this Oct 3, 2023
@debnath003
Copy link
Author

Can I update the comment? @appgurueu

@appgurueu
Copy link
Collaborator

Can I update the comment? @appgurueu

This is not about a comment, this is about the contents of this PR (adding a trivial rectangle class with area / perimeter functions) which I don't see adding much value. To quote the contribution guidelines:

[...] each algorithm in this repo should add a unique value

(note: we'll try to make it more clear in the future what our expectations are, and that we mostly aren't interested in trivial algorithms; if in doubt, open an issue before working on an implementation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants