Skip to content

Conversation

@debnath003
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@debnath003
Copy link
Author

@raklaptudirm @appgurueu please merge this PR and make this PR eligible for hacktoberfest

@debnath003
Copy link
Author

is this PR eligible for hacktoberfest? If so please merge this PR @raklaptudirm @appgurueu

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I see no point in making linear search recursive in JavaScript; rather, it is even risky, since if your runtime doesn't do tail call optimization, you will be wasting stack space and eventually stack overflow:

> recursiveLinearSearch(Array(1e7).fill(42), 69) Uncaught RangeError: Maximum call stack size exceeded 
@appgurueu appgurueu closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants