Skip to content

Reduce memory usage peak when using thumbnail animated WebP decoding and encoding #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Reduce memory usage peak when using thumbnail animated WebP decoding and encoding #73

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b25f9a
Support using CoreGraphics to produce scaled down CGImage directly
dreampiggy Mar 8, 2023
c779312
Use kvImageNoAllocate to avoid extra allocate for vImageBuffer when W…
dreampiggy Mar 8, 2023
9dae8d3
Refactory thumbnail decoding, use a transformed CGContext instead of …
dreampiggy Mar 9, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use kvImageNoAllocate to avoid extra allocate for vImageBuffer when W… 
…ebP encoding
  • Loading branch information
@dreampiggy
dreampiggy committed Mar 8, 2023
commit c7793128368c8d231ffb7989aa5cafb07ba47498
4 changes: 1 addition & 3 deletions SDWebImageWebPCoder/Classes/SDImageWebPCoder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,7 @@ - (nullable NSData *)sd_encodedWebpDataWithImage:(nullable CGImageRef)imageRef
}

vImage_Buffer src;
error = vImageBuffer_InitWithCGImage(&src, &srcFormat, nil, imageRef, kvImageNoFlags);
error = vImageBuffer_InitWithCGImage(&src, &srcFormat, nil, imageRef, kvImageNoAllocate);
if (error != kvImageNoError) {
vImageConverter_Release(convertor);
return nil;
Expand All @@ -792,15 +792,13 @@ - (nullable NSData *)sd_encodedWebpDataWithImage:(nullable CGImageRef)imageRef
error = vImageBuffer_Init(&dest, height, width, destFormat.bitsPerPixel, kvImageNoFlags);
if (error != kvImageNoError) {
vImageConverter_Release(convertor);
free(src.data);
return nil;
}

// Convert input color mode to RGB888/RGBA8888
error = vImageConvert_AnyToAny(convertor, &src, &dest, NULL, kvImageNoFlags);

// Free the buffer
free(src.data);
vImageConverter_Release(convertor);
if (error != kvImageNoError) {
free(dest.data);
Expand Down