Skip to content

Conversation

daltonclaybrook
Copy link
Contributor

Resoves #56

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #57 (0d018b5) into master (a1ea3c7) will increase coverage by 1.72%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #57 +/- ## ========================================== + Coverage 75.52% 77.24% +1.72%  ========================================== Files 2 2 Lines 813 813 ========================================== + Hits 614 628 +14  + Misses 199 185 -14 
Flag Coverage Δ
ios 77.24% <ø> (+1.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SDWebImageWebPCoder/Classes/SDImageWebPCoder.m 77.13% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ea3c7...0d018b5. Read the comment docs.

@dreampiggy
Copy link
Contributor

dreampiggy commented May 6, 2021

We can put this search path into the Project Level configuration, not just Target Level build settings.

I'll do this now.

@daltonclaybrook
Copy link
Contributor Author

@dreampiggy I believe that is what I've done. Happy to be proven wrong.

@dreampiggy
Copy link
Contributor

dreampiggy commented May 6, 2021

Seems you're right.

But...Actually, this component (including all SDWebImage submodules) does not have plan to long-way support Carthage, or XCFramework in Carthage.

Because I remember Carthage support need extra dependency to that .xcframework and create new Dummy Xcode scheme.

@dreampiggy dreampiggy merged commit 3a7ac0f into SDWebImage:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants