Skip to content

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Feb 1, 2021

Which cause the wrong encoded WebP image (each line repeats 3 times)

Compare

Original image:

TestImageGrayscale.jpg.zip

Before fix (Bug):

bug.webp.zip

After fix (Correct):

test.webp.zip

@dreampiggy dreampiggy changed the title Fix the issue when WebP Encoding grayscale image with only 1 channel,… Fix the issue when WebP Encoding grayscale image with only 1 channel Feb 1, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #53 (1903ac2) into master (cdf6ce8) will decrease coverage by 1.59%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #53 +/- ## ========================================== - Coverage 77.11% 75.52% -1.60%  ========================================== Files 2 2 Lines 804 813 +9 ========================================== - Hits 620 614 -6  - Misses 184 199 +15 
Flag Coverage Δ
ios 75.52% <85.71%> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SDWebImageWebPCoder/Classes/SDImageWebPCoder.m 75.40% <85.71%> (-1.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf6ce8...1903ac2. Read the comment docs.

@dreampiggy dreampiggy added the fix label Feb 2, 2021
@dreampiggy dreampiggy merged commit 2460818 into master Feb 2, 2021
@dreampiggy
Copy link
Contributor Author

This PR also fix the CMYK image's encoding issue.

Test image from Apple: https://developer.apple.com/documentation/accelerate/standardizing_arbitrary_image_formats_for_processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 participant