Fix that WebP image with ICC Profile does not show color correctly, should use the profile colorspace instead of device colorspace #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…hould use the profile colorspace instead of device colorspace
8 tasks
| @kinarob Hi. Since I found that you merge the 4.x version of WebP coder for the same PR, this one do the same thing. With the changes related to the Animation support. (Which 4.x does not have). Any extra idea ? |
kinarobin approved these changes Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See: SDWebImage/SDWebImage#2585
This is bugfix for 5.0 version WebP coder as well. Besides the code from master branch of SDWebImage.
Since now WebP coder support Animation protoocl. And Animation decoding need to query
animatedImageFrameAtIndex:really frequently, that ICC Profile colorSpace should be kept associated to coder instance, like what we've done for_canvasproperty.