Remove the extra SD_WEBP macro define. Since now we move to a dedicated repo #2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint
)This merge request fixes / reffers to the following issues: ...
Pull Request Description
In previous version of SDWebImage, we define a macro
SD_WEBP
to indicate that we supports WebP image and link libwebp third party dependency. Using the macro can avoid actually generate the unused class symbols and files for user who don't need webp (Which may increase the framework binary size).However, now, we move the
SDImageWebPCoder
into this dedicated repo. So this means, people who add dependency to our new repo indeed want WebP supports. ThoseSD_WEBP
macro define does not do anything.It's now time to remove them, to avoid unused extra process for some user (For example, in the previous version, if you need to build a embedded framework link the
SDWebImage/WebP
, you also to inherit thisSD_WEBP
macro in the Xcode project)