Skip to content

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Sep 17, 2018

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...

Pull Request Description

In previous version of SDWebImage, we define a macro SD_WEBP to indicate that we supports WebP image and link libwebp third party dependency. Using the macro can avoid actually generate the unused class symbols and files for user who don't need webp (Which may increase the framework binary size).

However, now, we move the SDImageWebPCoder into this dedicated repo. So this means, people who add dependency to our new repo indeed want WebP supports. Those SD_WEBP macro define does not do anything.

It's now time to remove them, to avoid unused extra process for some user (For example, in the previous version, if you need to build a embedded framework link the SDWebImage/WebP, you also to inherit this SD_WEBP macro in the Xcode project)

@bpoplauschi bpoplauschi merged commit 2a73606 into master Sep 18, 2018
@bpoplauschi bpoplauschi deleted the remove_sd_webp_macro branch September 18, 2018 14:59
dreampiggy pushed a commit that referenced this pull request Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants