Skip to content

Conversation

@mattzeunert
Copy link

Fix for #138.

I also noticed that removing the listeners wasn't working correctly. ::this.showTooltip creates a new function that's different from this.showTooltip, so it can't be removed with .removeEventListener('mouseenter', this.showTooltip).

@wwayne
Copy link
Collaborator

wwayne commented Jul 17, 2016

I think the function has been correctly removed, the most easy measure to test it is put a console.log into the showTooltip function to see if it would output only once every time showing the tooltip.

This problem only happens in HD screen, retina for example, someone mentioned this before, I didn't think it's obvious under effect float so I closed the ticket, but for solid, it would be a problem, will check this later.

@wwayne wwayne closed this Jul 17, 2016
@mattzeunert
Copy link
Author

Thanks. I checked with getEventListeners in Chrome and it showed lots of them.

Sorry about the build commit by the way. I started to load the forked branch locally with NPM and didn't realize doing a build on it would update the PR.

@wwayne
Copy link
Collaborator

wwayne commented Jul 17, 2016

Some PR to this component includes built files, so it's acceptable actually : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants