Support more placement options in TooltipTypes.d.ts #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Support more place types that floating-ui supports. These actually already work but I need the type to be updated to reflect existing allowed types.
gabrieljablonski requested changes Jun 23, 2023
Co-authored-by: Gabriel Jablonski <gabriel.g.jablonski@gmail.com>
Member
| Thanks for suggesting this. Before we can merge this, we have to update a few more files. Source:
Docs:
I believe I haven't missed any. Feel free to update them, or leave it to us for whenever we get the time. |
Updated types on place
Added more place types
Updated place example to include more types
removed semi-colons
Removed semi-colon
Contributor Author
I've updated those files. Hope that works. Have a great weekend! |
Contributor Author
| @gabrieljablonski sorry, I missed a big section in the docs. I will get to this later tonight.  |
Updated examples to include more placement types
Contributor Author
| @gabrieljablonski I updated the examples to include the other types... see screen recording Screen.Recording.2023-06-24.at.9.43.46.AM.mov |
gabrieljablonski approved these changes Jun 24, 2023
danielbarion approved these changes Jun 26, 2023
Member
| Available at |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Support more place types that floating-ui supports. These actually already work but I need the type to be updated to reflect existing allowed types.