pp model support dpo. #181
Open
+138 −25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (7.54%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
@@ Coverage Diff @@ ## develop #181 +/- ## ========================================= Coverage ? 7.54% ========================================= Files ? 2 Lines ? 53 Branches ? 14 ========================================= Hits ? 4 Misses ? 47 Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| state_dict[self._pp_to_single_mapping[k]] = v | ||
| | ||
| return state_dict | ||
| |
Contributor
There was a problem hiding this comment.
这里不能删，可能会影响权重名称的映射，dpo 如果set_state_dict 有问题，是不是提供一个做了名字映射的方法进行覆盖
From00 reviewed Dec 18, 2025
| @@ -291,6 +296,9 @@ def __init__(self, layers, strategy): | |||
| # default loss function index | |||
| self.loss_fn_idx = 0 | |||
| | |||
| def is_pipeline_last_stage(self, ignore_virtual=False): | |||
Contributor Author
There was a problem hiding this comment.
…into support_pp_model_dpo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.