Skip to content

Fix compilation under MSVC #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix compilation under MSVC #7

wants to merge 3 commits into from

Conversation

@Shatur
Copy link

@Shatur Shatur commented Jul 29, 2021 •
edited
Loading

PR removes experimental/filesystem header file as it is no longer required after #5. The header also causes the following error on MSVC:

fatal error C1189: #error: The <experimental/filesystem> header providing std::experimental::filesystem is deprecated by Microsoft and will be REMOVED. It is superseded by the C++17 <filesystem> header providing std::filesystem. You can define _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING to acknowledge that you have received this warning.

Also on Windows it's required to include Flex include directories to get access to FlexLexer.h.
@Shatur Shatur force-pushed the remove-old-header branch from ca47ad1 to fd25d27 Compare July 29, 2021 08:20
@Shatur Shatur changed the title Remove experimental filesystem header Fix compilation under MSVC Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@Shatur