Change game calendar to Gregorian calendar, fixing leap year calcs #3548
+32 −36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LeftofZen force-pushed the fixLeapYearCalc branch from 1d95bcf to cb2941e Compare LeftofZen changed the title 
LeftofZen commented Dec 16, 2025
| // Count the years and add an extra day for when there isn't leap year | ||
| if (day > kDaysInYear) | ||
| auto y = kBaseYear; | ||
| while (totalDays > 365) |
Contributor Author
There was a problem hiding this comment.
this isn't that efficient, if anyone can come up with a closed form solution that'd be cool
LeftofZen force-pushed the fixLeapYearCalc branch from cb2941e to f544abb Compare 
Member
| This changes the simulation, if slightly, so I suggest we consider this for the next milestone. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #3547