pool: Track connections and prohibit using them after release. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elprans approved these changes Mar 29, 2017
asyncpg/pool.py Outdated
| if not self._in_pool: | ||
| raise exceptions.InterfaceError( | ||
| f'cannot call Connection.{meth.__name__}(): ' | ||
| f'connection is no longer in the pool') |
There was a problem hiding this comment.
'connection has been released back to the pool'
asyncpg/pool.py Outdated
| | ||
| def __repr__(self): | ||
| if self._con is None: | ||
| return f'<{self.__class__.__name__} [not in pool] {id(self):#x}>' |
asyncpg/pool.py Outdated
| event loop will be used. | ||
| :return: An instance of :class:`~asyncpg.pool.Pool`. | ||
| .. versionchanged:: 0.9.1 |
asyncpg/pool.py Outdated
| :return: An instance of :class:`~asyncpg.pool.Pool`. | ||
| .. versionchanged:: 0.9.1 | ||
| Pool prohibits use of its connections after they were released. |
There was a problem hiding this comment.
An InterfaceError will be raised on any attempted operation on a released connection.
elprans approved these changes Mar 29, 2017
1st1 force-pushed the pool_proxy branch 2 times, most recently from 053024f to 8ccaecc Compare Connection pool now wraps all connections in `PooledConnectionProxy` objects to raise `InterfaceError` if they are used after being released back to the pool. We also check if connection passed to `pool.release` actually belong to the pool and correctly handle multiple calls to `pool.release` with the same connection object. `PooledConnectionProxy` transparently wraps Connection instances, exposing all Connection public API. `isinstance(asyncpg.connection.Connection)` is `True` for Instances of `PooledConnectionProxy` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Connection pool now wraps all connections in
PooledConnectionProxyobjects to raiseInterfaceErrorif they are used after being released back to the pool. We also check if connection passed topool.releaseactually belong to the pool and correctly handle multiple calls topool.releasewith the same connection object.PooledConnectionProxytransparently wraps Connection instances, exposing all Connection public API.isinstance(asyncpg.connection.Connection)isTruefor Instances ofPooledConnectionProxyclass.