Skip to content

Target session attr (2) #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 8, 2023
Merged

Target session attr (2) #987

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
bf6033c
Add target session attribute connection param
Aug 27, 2022
bee17cb
Fixed tests so they pass on windows.
Dec 7, 2022
1c67511
push for workflows
Dec 8, 2022
fae9d9c
push for workflows
Dec 8, 2022
7a847ce
no image for python 3.6
Dec 8, 2022
a3d7342
merge ci changes from master
Dec 8, 2022
7d9234f
merge setup.py changes from master
Dec 11, 2022
a43b064
Add logging to server selection procedure
Dec 12, 2022
24ea4e5
formatting
Dec 12, 2022
3df816d
undo mistake
Dec 12, 2022
e24a091
fix test?
Dec 12, 2022
38984a6
disable tests for pg11 to see if all the rest of the test cases pass
Dec 12, 2022
86423c3
disable tests for pg11 to see if all the rest of the test cases pass
Dec 15, 2022
277ed96
add some more fixes that were already implemented
Dec 16, 2022
5737f76
Add support for read-write and read-only target_session_attribute opt…
Dec 16, 2022
c3133c0
fix little logical error
Dec 16, 2022
ae325ba
linter
Dec 16, 2022
980004c
Merge branch 'master' into target_session_attr
JesseDeLoore Dec 17, 2022
3bc8322
fix logic issue
Dec 18, 2022
4e97acc
Merge branch 'target_session_attr' of github.com:JesseDeLoore/asyncpg…
Dec 18, 2022
d824333
Update based on review.
Jan 29, 2023
08ad1f8
fix tests
Jan 29, 2023
7cdd2ba
See the results on pg11
Jan 29, 2023
19b7a17
...
Jan 30, 2023
ea002ed
Apply fix
May 4, 2023
9f1d836
Merge branch 'master' into target_session_attr
JesseDeLoore May 5, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter
  • Loading branch information
Jesse De Loore committed Dec 16, 2022
commit ae325ba83c075ef11dfaa3cef86f427ab0ab17dc
4 changes: 2 additions & 2 deletions asyncpg/connect_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,9 +917,9 @@ def _accept_read_only(should_be_read_only: bool):
"""
async def can_be_used(connection):
settings = connection.get_settings()
is_read_only = getattr(settings, 'default_transaction_read_only', 'off')
is_readonly = getattr(settings, 'default_transaction_read_only', 'off')

if should_be_read_only and is_read_only == "on":
if should_be_read_only and is_readonly == "on":
return True
return await _accept_in_hot_standby(should_be_read_only)(connection)
return can_be_used
Expand Down