Adopt PEP 621, move metadata into pyproject.toml #904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PEP 621 is supported in setuptools starting from version 61, not 60.
| I ended up fixing this properly in #1045 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#900 (comment)
As @abravalheri advised, we should either drop the
[project]table (#903) or fully adopt PEP 621 (this PR). However, since the support forpyproject.tomlofsetuptoolsis still experimental and requires a fairly highsetuptoolsversion, we'd better wait at least until it stabilizes andasyncpgofficially drops the compatibility with Python 3.6. I will keep tracking on this.If the maintainers are never willing to adopt PEP 621 even in the foreseeable future, just close this PR.