Complete typing of connresource #1202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DanielNoord commented Oct 30, 2024
| | ||
| def guarded(meth): | ||
| _ConnectionResourceT = TypeVar( | ||
| "_ConnectionResourceT", bound="ConnectionResource", contravariant=True |
There was a problem hiding this comment.
The bound needs to be stringified, even with from __future__ import annotations. I checked this locally.
elprans approved these changes Dec 18, 2024
| @elprans Same questions here: could you retrigger the CI so this can get merged? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We can actually enable
mypy --strictfor this module now :)Typing decorators correctly is notoriously hard and you need some pretty advanced concepts, but this does the trick. I have checked and both
pyrightandmypyconsider this to be the correct type for all call sites toguarded.The rest is pretty straightforward. The changes outside of the module are because
mypy --strictdoesn't allow calls to untyped functions, which I therefore had to fix.