Skip to content

Add max_inactive_connection_lifetime parameter to Pool. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2017
Merged

Add max_inactive_connection_lifetime parameter to Pool. #110

merged 1 commit into from
Mar 31, 2017

Conversation

@1st1
Copy link
Member

@1st1 1st1 commented Mar 31, 2017

No description provided.

@1st1 1st1 requested a review from elprans March 31, 2017 17:59
@1st1 1st1 force-pushed the max_inactive branch 3 times, most recently from 94d5e97 to 5cf04bf Compare March 31, 2017 19:16
elprans
elprans reviewed Mar 31, 2017
View reviewed changes
asyncpg/pool.py
return proxy

async def release(self):
self._in_use = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert self._in_use
asyncpg/pool.py Outdated
raise ex

assert self._inactive_callback is None
if self._max_inactive_time:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and self._con is not None
asyncpg/_testbase.py
min_size=10,
max_size=10,
max_queries=50000,
max_inactive_connection_lifetime=60.0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default should be 0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's bump this to something like 300.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done
@1st1 1st1 merged commit a2935ae into master Mar 31, 2017
@elprans elprans deleted the max_inactive branch April 4, 2017 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@1st1 @elprans