Rollback any active transaction in Connection.reset() #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elprans approved these changes Mar 30, 2017
| 'message': 'Resetting connection with an ' | ||
| 'active transaction {!r}'.format(self) | ||
| }) | ||
| _reset_query.append('ROLLBACK;') |
There was a problem hiding this comment.
Managed transaction (self._top_xact) needs to be checked and put in order as well.
In detail: 1. If there is an active transaction, `Connection.reset()` will rollback it, along with issuing a warning. Both transactions started with `Connection.transaction()` and manually started with `Connection.execute('BEGIN;')` are supported. 2. It's no longer possible to start a transaction using `Connection.transaction()` API if the connection is in a manually started transaction. 3. New `assertLoopErrorHandlerCalled` helper method for asyncpg TestCase. Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.