pool: Add another level of indirection to the pool internal logic #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1st1 force-pushed the new_pool branch 8 times, most recently from 8e3e355 to 367a769 Compare 
elprans approved these changes Mar 29, 2017
asyncpg/pool.py Outdated
| self._setup = setup | ||
| self._init = init | ||
| | ||
| async def connect(self, *, queue=True): |
Make internal connection pool queue reference a new intermediate object -- PoolConnectionHolder -- instead of Connections directly. PoolConnectionHolder fully encapsulates the management of one connection: * connection logic; * handling closed connections; * handling connections that exceeded max-queries quota; etc. The new logic guarantees that old and new connections are always added back to the pool (1), removes a deadlock in pool.acquire (2), uses a LIFO queue to take advantage of "min_size" pool parameter (3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Make internal connection pool queue reference a new intermediate
object -- PoolConnectionHolder -- instead of Connections directly.
PoolConnectionHolder fully encapsulates the management of one
connection:
The new logic guarantees that old and new connections are always
added back to the pool (1), removes a deadlock in pool.acquire (2),
uses a LIFO queue to take advantage of "min_size" pool parameter.