Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Dec 17, 2025

What does this PR do?

Revert part of #21413, fix #21424

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21427.org.readthedocs.build/en/21427/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (5130530) to head (61f76a2).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (5130530) and HEAD (61f76a2). Click for more details.

HEAD has 381 uploads less than BASE
Flag BASE (5130530) HEAD (61f76a2)
cpu 118 30
lightning_fabric 30 0
pytest 59 0
python3.12 36 9
lightning 58 15
python3.11 24 6
python3.10 11 3
python3.12.7 35 9
python 12 3
pytorch2.4.1 6 3
pytest-full 59 30
pytorch_lightning 30 15
pytorch2.7 6 3
pytorch2.1 11 6
pytorch2.3 6 3
pytorch2.2.2 6 3
pytorch2.9 6 3
pytorch2.5.1 6 3
pytorch2.8 6 3
pytorch2.6 6 3
Additional details and impacted files
@@ Coverage Diff @@ ## master #21427 +/- ## ========================================= - Coverage 87% 79% -8%  ========================================= Files 269 266 -3 Lines 23822 23767 -55 ========================================= - Hits 20633 18736 -1897  - Misses 3189 5031 +1842 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package

3 participants