Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Sep 2, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21145.org.readthedocs.build/en/21145/

@github-actions github-actions bot added the ci Continuous Integration label Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (14a57c7) to head (9388198).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #21145 +/- ## ======================================== - Coverage 87% 87% -1%  ======================================== Files 269 269 Lines 23568 23568 ======================================== - Hits 20551 20419 -132  - Misses 3017 3149 +132 
@Borda Borda merged commit c3ca8a5 into Lightning-AI:master Sep 2, 2025
75 checks passed
@matsumotosan matsumotosan deleted the fix-matrix-requires branch September 2, 2025 11:48
Borda added a commit that referenced this pull request Sep 3, 2025
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit c3ca8a5)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> (cherry picked from commit c3ca8a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration

3 participants