Add proper styled-components optimisation #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This implements specific rendering logic that skips StyledComponents entirely, if a new enough version of styled-component is installed and the optimisation can be applied. It does this by computing "attrs" manually and skipping the styled-components logic entirely by rendering the target directly.
kitten force-pushed the fix-styled-components-optimisation branch from 9dc822f to bed10b1 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #3 +/- ## ========================================== - Coverage 100% 97.07% -2.93% ========================================== Files 9 10 +1 Lines 439 479 +40 Branches 72 84 +12 ========================================== + Hits 439 465 +26 - Misses 0 10 +10 - Partials 0 4 +4
Continue to review full report at Codecov.
|
Any component wrapped in a forwardRef could have a styledComponentId, since this is a well-known hack.
kitten force-pushed the fix-styled-components-optimisation branch from 0878666 to bb13db6 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.