Skip to content

Conversation

@lucia-sb
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged
hestonhoffman
hestonhoffman previously approved these changes Dec 22, 2025
steveny91
steveny91 previously approved these changes Dec 22, 2025
Co-authored-by: Steven Yuen <steven.yuen@datadoghq.com>
@lucia-sb lucia-sb dismissed stale reviews from steveny91 and hestonhoffman via 1dccb35 December 22, 2025 17:18
@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (7.75.x@a65f313). Learn more about missing BASE report.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 22, 2025

⚠️ Tests

Fix all issues with Cursor

⚠️ Warnings

❄️ 3 New flaky tests detected

test_backend_transaction_age from test_pg_integration.py (Datadog) (Fix with Cursor)
Needed exactly 1 candidates for 'postgresql.activity.backend_xmin_age', got 0 Expected: MetricStub(name='postgresql.activity.backend_xmin_age', type=None, value=1, tags=['app:test_backend_transaction_age_1766424303.547514', 'database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5432', 'postgresql_cluster_name:primary', 'postgresql_version:12.17', 'replication_role:master', 'system_identifier:7586734383634153502', 'user:datadog'], hostname=None, device=None, flush_first_value=None) Difference to closest: Expected name: postgresql.activity.backend_xmin_age Found postgresql.activity.backend_xid_age Similar submitted: Score Most similar 0.97 MetricStub(name='postgresql.activity.backend_xid_age', type=0, value=1.0, tags=['app:test_backend_transaction_age_1766424303.547514', 'database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5432', 'postgresql_cluster_name:primary', 'postgresql_version:12.17', 'replication_role:master', 'system_identifier:7586734383634153502', 'user:datadog'], hostname='stubbed.hostname', device=None, flush_first_value=False) ... 
test_common_metrics[True] from test_pg_integration.py (Datadog) (Fix with Cursor)
Some metrics are collected but not asserted: Asserted Metrics:	- dd.postgres.operation.time	- postgresql.activity.wait_event	- postgresql.archiver.archived_count	- postgresql.archiver.failed_count	- postgresql.before_xid_wraparound	- postgresql.bgwriter.buffers_alloc	- postgresql.bgwriter.buffers_backend	- postgresql.bgwriter.buffers_backend_fsync ... 
test_conflicts_snapshot from test_pg_replication.py (Datadog) (Fix with Cursor)
Needed at least 1 candidates for 'postgresql.conflicts.snapshot', got 0 Expected: MetricStub(name='postgresql.conflicts.snapshot', type=None, value=1, tags=['database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5434', 'postgresql_version:12.17', 'replication_role:standby'], hostname=None, device=None, flush_first_value=None) Difference to closest: Expected name: postgresql.conflicts.snapshot Found postgresql.conflicts.lock Similar submitted: Score Most similar 0.89 MetricStub(name='postgresql.conflicts.lock', type=3, value=1.0, tags=['database_hostname:stubbed.hostname', 'database_instance:stubbed.hostname', 'db:datadog_test', 'dd.internal.resource:database_instance:stubbed.hostname', 'foo:bar', 'port:5434', 'postgresql_version:12.17', 'replication_role:standby'], hostname='stubbed.hostname', device=None, flush_first_value=False) ... 

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1dccb35 | Docs | Datadog PR Page | Was this helpful? Give us feedback!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment