stdClass instead of AssocArray #4 #150
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jkowalleck force-pushed the json-normalizer-no-AssocArray-but-stdClass branch 3 times, most recently from cadf8d9 to 5a53240 Compare Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck force-pushed the json-normalizer-no-AssocArray-but-stdClass branch from 5a53240 to eff67f9 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #4
after writing it, and having more usefull typing, i dont think that i like the resulting code.
the benefits are not that much - is my current feeling.